From 7a9f50c0dacfe93174172f3cc54c8a3db0e32c98 Mon Sep 17 00:00:00 2001 From: coderaiser Date: Fri, 13 Jan 2017 15:51:48 +0200 Subject: [PATCH] refactor(cloudcmd) authCheck: early return --- server/cloudcmd.js | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/server/cloudcmd.js b/server/cloudcmd.js index d0b0bacf..cc5b8ee8 100644 --- a/server/cloudcmd.js +++ b/server/cloudcmd.js @@ -103,12 +103,11 @@ function authCheck(socket, success) { const isName = name === config('username'); const isPass = pass === config('password'); - if (isName && isPass) { - success(); - socket.emit('accept'); - } else { - socket.emit('reject'); - } + if (!isName || !isPass) + return socket.emit('reject'); + + success(); + socket.emit('accept'); }); }