From 615a80a132d41205e9d32ab8251c475ad99be70b Mon Sep 17 00:00:00 2001
From: coderaiser <mnemonic.enemy@gmail.com>
Date: Fri, 6 Dec 2013 13:59:56 +0000
Subject: [PATCH] refactor(dropbox) public -> private: mkDir, readDir,
 readFile, writeFile

---
 lib/client/storage/_dropbox.js | 119 ++++++++++++++++-----------------
 1 file changed, 59 insertions(+), 60 deletions(-)

diff --git a/lib/client/storage/_dropbox.js b/lib/client/storage/_dropbox.js
index 3cce3cb5..3fb7bb8f 100644
--- a/lib/client/storage/_dropbox.js
+++ b/lib/client/storage/_dropbox.js
@@ -84,8 +84,57 @@ var CloudCmd, Util, DOM, Dropbox, cb, Client;
           
         };
         
+        this.read           = function(path, callback) {
+            Client.stat(path, function(error, stat) {
+                var msg, read;
+                
+                if (error)
+                     msg        = error.responseText;
+                else {
+                    if (stat.isFile)
+                        read    = readFile;
+                    else
+                        read    = readDir;
+                    
+                    read(path, callback);
+                }
+            });
+        };
         
-        this.readDir        = function(dirPath, callback) {
+        this.save           = function(path, data, callback, query) {
+            if (query === '?dir')
+                mkDir(path, callback);
+            else
+                writeFile(path, data, callback);
+        };
+        
+        this.getToken       = function() {
+            return Client.credentials().token;
+        };
+        
+        /**
+         * upload file to DropBox
+         */
+        this.uploadFile      = function(pParams, pCallBack){
+            var lContent    = pParams.data,
+                lName       = pParams.name;
+            
+            if(lContent){
+                DOM.Images.showLoad();
+                if(!lName)
+                    lName = Util.getDate();
+                
+                Client.writeFile(lName, lContent, function(pError, pData){
+                    DOM.Images.hideLoad();
+                    Util.log(pError || pData);
+                    Util.exec(pCallBack);
+                });
+            }
+            
+            return lContent;
+        };
+        
+        function readDir(dirPath, callback) {
             var path = dirPath || '/';
             
             Client.readdir(path, function(error, names, obj, files) {
@@ -117,9 +166,13 @@ var CloudCmd, Util, DOM, Dropbox, cb, Client;
                 
                 Util.exec(callback, msg, json);
             });
-        };
+        }
         
-        this.readFile       = function(name, callback) {
+        function mkDir(path, callback) {
+            Client.mkdir(path, callback);
+        }
+        
+        function readFile(name, callback) {
             Client.readFile(name, function(error, data) {
                 var msg;
                 
@@ -128,33 +181,9 @@ var CloudCmd, Util, DOM, Dropbox, cb, Client;
                 
                 callback(msg, data);
             });
-        };
+        }
         
-        this.read           = function(path, callback) {
-            Client.stat(path, function(error, stat) {
-                var msg, read;
-                
-                if (error)
-                     msg        = error.responseText;
-                else {
-                    if (stat.isFile)
-                        read    = DropBoxStore.readFile;
-                    else
-                        read    = DropBoxStore.readDir;
-                    
-                    read(path, callback);
-                }
-            });
-        };
-        
-        this.save           = function(path, data, callback, query) {
-            if (query === '?dir')
-                DropBoxStore.mkDir(path, callback);
-            else
-                DropBox.writeFile(path, data, callback);
-        };
-        
-        this.writeFile       = function(name, data, callback) {
+        function writeFile(name, data, callback) {
             Client.writeFile(name, data, function(error, data) {
                 var msg;
                 
@@ -163,37 +192,7 @@ var CloudCmd, Util, DOM, Dropbox, cb, Client;
                 
                 callback(msg, data);
             });
-        };
-        
-        this.mkDir          = function(path, callback) {
-            Client.mkdir(path, callback);
-        };
-        
-        this.getToken       = function() {
-            return Client.credentials().token;
-        };
-        
-        /**
-         * upload file to DropBox
-         */
-        this.uploadFile      = function(pParams, pCallBack){
-            var lContent    = pParams.data,
-                lName       = pParams.name;
-            
-            if(lContent){
-                DOM.Images.showLoad();
-                if(!lName)
-                    lName = Util.getDate();
-                
-                Client.writeFile(lName, lContent, function(pError, pData){
-                    DOM.Images.hideLoad();
-                    Util.log(pError || pData);
-                    Util.exec(pCallBack);
-                });
-            }
-            
-            return lContent;
-        };
+        }
         
         init(pCallBack);
     }