Mirrors/cloudcmd
1
0
Fork 0
mirror of https://github.com/coderaiser/cloudcmd.git synced 2026-01-23 02:35:49 +00:00
Code Issues Projects Releases Wiki Activity

feature: terminal: get rid of mock-require

Browse source
This commit is contained in:
coderaiser 2024-03-22 10:52:25 +02:00
parent cfa3d69538
commit 4e32241d83
2 changed files with 15 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

8
server/terminal.js
View file

@ -8,11 +8,15 @@ const noop = (req, res, next) => {
noop.listen = noop;
module.exports = (config, arg) => {
function _getModule(a) {
return require(a);
}
module.exports = (config, arg, {getModule = _getModule} = {}) => {
if (!config('terminal'))
return noop;
const [e, terminalModule] = tryCatch(require, config('terminalPath'));
const [e, terminalModule] = tryCatch(getModule, config('terminalPath'));
if (!e && !arg)
return terminalModule;

25
server/terminal.spec.js
View file

@ -2,13 +2,8 @@
const {test, stub} = require('supertape');
const mockRequire = require('mock-require');
const terminal = require('./terminal');
const {createConfigManager} = require('./cloudcmd');
const terminalPath = './terminal';
const {stopAll} = mockRequire;
test('cloudcmd: terminal: disabled', (t) => {
const config = createConfigManager();
@ -33,13 +28,12 @@ test('cloudcmd: terminal: disabled: listen', (t) => {
test('cloudcmd: terminal: enabled', (t) => {
const term = stub();
const arg = 'hello';
const config = stub().returns(true);
const getModule = stub().returns(term);
mockRequire(terminalPath, term);
const terminal = require(terminalPath);
terminal(arg);
stopAll();
terminal(config, arg, {
getModule,
});
t.calledWith(term, [arg], 'should call terminal');
t.end();
@ -67,16 +61,15 @@ test('cloudcmd: terminal: enabled: no string', (t) => {
test('cloudcmd: terminal: no arg', (t) => {
const gritty = {};
mockRequire('gritty', gritty);
const getModule = stub().returns(gritty);
const config = createConfigManager();
config('terminal', true);
config('terminalPath', 'gritty');
const result = terminal(config);
stopAll();
const result = terminal(config, '', {
getModule,
});
t.equal(result, gritty);
t.end();