From 1e27733c383e7e747ae686c32268a9c7f1a0e1dc Mon Sep 17 00:00:00 2001 From: coderaiser Date: Wed, 5 Nov 2014 10:44:41 -0500 Subject: [PATCH] refactor(config) getValue --- lib/client/config.js | 39 ++++++++++++++++++++++++--------------- 1 file changed, 24 insertions(+), 15 deletions(-) diff --git a/lib/client/config.js b/lib/client/config.js index a4d856c2..776d8b15 100644 --- a/lib/client/config.js +++ b/lib/client/config.js @@ -125,10 +125,10 @@ var CloudCmd, Util, DOM; name = el.id, type = el.type; - switch(type) { - case 'checkbox': - data = el.checked; - + obj[name] = + data = getValue(el); + + if (type === 'checkbox') if (el.id === 'localStorage') onLocalStorageChange(data); else if (el.id === 'diff') @@ -139,17 +139,6 @@ var CloudCmd, Util, DOM; onLSChange(data); else if (el.id === 'auth') onAuthChange(data); - - break; - case 'number': - data = el.value - 0; - break; - default: - data = el.value; - break; - } - - obj[name] = data; if (name === 'notifications') { if (data && !Notify.check()) @@ -162,6 +151,26 @@ var CloudCmd, Util, DOM; }); } + function getValue(el) { + var data, + type = el.type; + + switch(type) { + case 'checkbox': + data = el.checked; + + break; + case 'number': + data = el.value - 0; + break; + default: + data = el.value; + break; + } + + return data; + } + function onLocalStorageChange(checked) { var elDiff = DOM.getById('diff', Element), elBuffer = DOM.getById('buffer', Element),