From 02dbe56d79ca43403342bee2af49fa06cd5e567d Mon Sep 17 00:00:00 2001
From: coderiaser <coderaiser@cloudcmd.io>
Date: Mon, 23 Mar 2026 12:20:31 +0200
Subject: [PATCH] feature: server: user-menu: when error send it

---
 server/user-menu.js      | 24 ++++++++++++++++--------
 server/user-menu.spec.js | 19 +++++++++++++++++++
 2 files changed, 35 insertions(+), 8 deletions(-)

diff --git a/server/user-menu.js b/server/user-menu.js
index 4c56ad9f..84baf1a3 100644
--- a/server/user-menu.js
+++ b/server/user-menu.js
@@ -1,7 +1,6 @@
 import {homedir} from 'node:os';
 import {readFile as _readFile} from 'node:fs/promises';
 import {join} from 'node:path';
-import {readFileSync} from 'node:fs';
 // warm up worker cache
 import montag from 'montag';
 import {tryToCatch} from 'try-to-catch';
@@ -35,7 +34,9 @@ async function onGET({req, res, menuName, readFile}) {
     const url = req.url.replace(PREFIX, '');
     
     if (url === '/default')
-        return await sendDefaultMenu(res);
+        return await sendDefaultMenu(res, {
+            readFile,
+        });
     
     const {findUp} = await import('find-up');
     
@@ -58,7 +59,9 @@ async function onGET({req, res, menuName, readFile}) {
             .send(e.message);
     
     if (e)
-        return await sendDefaultMenu(res);
+        return await sendDefaultMenu(res, {
+            readFile,
+        });
     
     const [parseError, result] = await transpile(source);
     
@@ -86,8 +89,10 @@ function getError(error, source) {
     `;
 }
 
-async function sendDefaultMenu(res) {
-    const menu = await getDefaultMenu();
+async function sendDefaultMenu(res, {readFile}) {
+    const menu = await getDefaultMenu({
+        readFile,
+    });
     
     res
         .type('js')
@@ -106,10 +111,13 @@ async function transpile(source) {
     });
 }
 
-async function getDefaultMenu() {
+async function getDefaultMenu({readFile}) {
     const DEFAULT_MENU_PATH = new URL('../static/user-menu.js', import.meta.url).pathname;
-    const menu = readFileSync(DEFAULT_MENU_PATH, 'utf8');
-    const [, result] = await transpile(menu);
+    const menu = await readFile(DEFAULT_MENU_PATH, 'utf8');
+    const [error, result] = await transpile(menu);
+    
+    if (error)
+        return String(error);
     
     return result.code;
 }
diff --git a/server/user-menu.spec.js b/server/user-menu.spec.js
index b88cb07a..b24bb9eb 100644
--- a/server/user-menu.spec.js
+++ b/server/user-menu.spec.js
@@ -86,6 +86,25 @@ test('cloudcmd: user menu: io.cp', async (t) => {
     t.end();
 });
 
+test('cloudcmd: user menu: broken file', async (t) => {
+    const readFile = stub().returns('sdfsdf /; s');
+    const options = {
+        menuName: '.cloudcmd.menu.js',
+        readFile,
+    };
+    
+    const {request} = serveOnce(userMenu);
+    
+    const {body} = await request.get(`/api/v1/user-menu/default`, {
+        options,
+    });
+    
+    const expected = 'SyntaxError: Unexpected token (1:8)';
+    
+    t.equal(body, expected);
+    t.end();
+});
+
 function getUserMenuFile() {
     const userMenuFile = readFileSync(userMenuPath, 'utf8');
     const {code} = putout(userMenuFile, {