From 8bed364bb3cec2899d36f80fb8bbabb4e7044f2a Mon Sep 17 00:00:00 2001 From: Sergey Stepanov Date: Tue, 5 Jan 2021 00:22:37 +0300 Subject: [PATCH] Remove useless lock in the custom track sample struct --- pkg/webrtc/track.go | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/pkg/webrtc/track.go b/pkg/webrtc/track.go index 9e2e5d20..0534a8c7 100644 --- a/pkg/webrtc/track.go +++ b/pkg/webrtc/track.go @@ -2,7 +2,6 @@ package webrtc import ( "strings" - "sync" "github.com/pion/rtp" "github.com/pion/rtp/codecs" @@ -17,7 +16,6 @@ type CustomTrackSample struct { packetizer rtp.Packetizer rtpTrack *webrtc.TrackLocalStaticRTP clockRate float64 - mu sync.RWMutex } func NewCustomTrackSample(c webrtc.RTPCodecCapability, id, streamID string) (*CustomTrackSample, error) { @@ -43,9 +41,6 @@ func (s *CustomTrackSample) Bind(t webrtc.TrackLocalContext) (webrtc.RTPCodecPar return codec, err } - s.mu.Lock() - defer s.mu.Unlock() - if s.packetizer != nil { return codec, nil } @@ -72,10 +67,7 @@ func (s *CustomTrackSample) Unbind(t webrtc.TrackLocalContext) error { } func (s *CustomTrackSample) WriteSampleWithTimestamp(sample media.Sample, timestamp uint32) (err error) { - s.mu.RLock() - p := s.packetizer - clockRate := s.clockRate - s.mu.RUnlock() + p, clockRate := s.packetizer, s.clockRate if p == nil { return nil