Mirrors/PrivateBin
1
0
Fork 0
mirror of https://github.com/PrivateBin/PrivateBin.git synced 2026-07-17 16:39:40 +00:00
Code Issues Projects Releases Wiki Activity

add test to catch URL path extraction not removing query

Browse source
This commit is contained in:
El RIDO 2026-06-15 23:05:27 +02:00
parent 597a6f0d12
commit e3041700cf
No known key found for this signature in database
GPG key ID: 0F5C940A6BD81F92
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
tst/RequestTest.php
View file

@ -218,6 +218,7 @@ class RequestTest extends TestCase
{ {
$this->reset(); $this->reset();
$id = Helper::getRandomId(); $id = Helper::getRandomId();
$path = '/' . $this->getRandomQueryChars() . '/';
$queryParams = array($id); $queryParams = array($id);
$queryParamCount = random_int(1, 5); $queryParamCount = random_int(1, 5);
for ($i = 0; $i < $queryParamCount; ++$i) { for ($i = 0; $i < $queryParamCount; ++$i) {
@ -226,8 +227,10 @@ class RequestTest extends TestCase
shuffle($queryParams); shuffle($queryParams);
$_SERVER['REQUEST_METHOD'] = 'GET'; $_SERVER['REQUEST_METHOD'] = 'GET';
$_SERVER['QUERY_STRING'] = implode('&', $queryParams); $_SERVER['QUERY_STRING'] = implode('&', $queryParams);
$_SERVER['REQUEST_URI'] = $path . '?' . $_SERVER['QUERY_STRING'];
$_GET[$id] = ''; $_GET[$id] = '';
$request = new Request; $request = new Request;
$this->assertEquals($id, $request->getParam('pasteid')); $this->assertEquals($id, $request->getParam('pasteid'));
$this->assertEquals($path, $request->getRequestUri());
} }
} }