Mirrors/PrivateBin
1
0
Fork 0
mirror of https://github.com/PrivateBin/PrivateBin.git synced 2026-07-17 16:39:40 +00:00
Code Issues Projects Releases Wiki Activity

Use a string statusCode in the YourlsProxy test

Browse source 
YOURLS returns the status code as a string (see #1844); mirror that in
the regression test so it stays correct if the comparison ever changes.
This commit is contained in:
TowyTowy 2026-07-14 08:51:35 +02:00
parent a0c0d154ee
commit bb8b77d714
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
tst/YourlsProxyTest.php
View file

@ -139,8 +139,9 @@ class YourlsProxyTest extends TestCase
{ {
// YOURLS may reply with statusCode 200 but without a shorturl field; // YOURLS may reply with statusCode 200 but without a shorturl field;
// this must be handled gracefully as an error instead of raising a // this must be handled gracefully as an error instead of raising a
// TypeError (the method is declared to return ?string) // TypeError (the method is declared to return ?string). YOURLS returns
file_put_contents($this->_mock_yourls_service, '{"statusCode":200}'); // the status code as a string, so mirror that here.
file_put_contents($this->_mock_yourls_service, '{"statusCode":"200"}');
$yourls = new YourlsProxy($this->_conf, 'https://example.com/?foo#bar'); $yourls = new YourlsProxy($this->_conf, 'https://example.com/?foo#bar');
$this->assertTrue($yourls->isError()); $this->assertTrue($yourls->isError());