Mirrors/KasmVNC
1
0
Fork 0
mirror of https://github.com/kasmtech/KasmVNC.git synced 2026-07-17 16:36:49 +00:00
Code Issues Projects Releases Wiki Activity

VNC-151 Switch VNCServerST client iteration to use range-based loops

Browse source
This commit is contained in:
El 2026-03-11 10:12:02 +00:00
parent d000acaaa7
commit b5aa33de1c
No known key found for this signature in database
GPG key ID: EB3F4C9EA29CDE59
1 changed files with 17 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

36
common/rfb/VNCServerST.cxx
View file

@ -1121,39 +1121,37 @@ void VNCServerST::writeUpdate()
if (watermarkData)
updateWatermark();
for (ci = clients.begin(); ci != clients.end(); ci = ci_next) {
ci_next = ci; ci_next++;
for (auto client : clients) {
if (permcheck)
(*ci)->recheckPerms();
client->recheckPerms();
if (trackingFrameStats == network::GetAPIMessager::WANT_FRAME_STATS_ALL ||
(trackingFrameStats == network::GetAPIMessager::WANT_FRAME_STATS_OWNER &&
(*ci)->is_owner()) ||
client->is_owner()) ||
(trackingFrameStats == network::GetAPIMessager::WANT_FRAME_STATS_SPECIFIC &&
strstr((*ci)->getPeerEndpoint(), trackingClient))) {
strstr(client->getPeerEndpoint(), trackingClient))) {
(*ci)->setFrameTracking();
client->setFrameTracking();
// Only one owner
if (trackingFrameStats == network::GetAPIMessager::WANT_FRAME_STATS_OWNER)
trackingFrameStats = network::GetAPIMessager::WANT_FRAME_STATS_SERVERONLY;
}
(*ci)->add_copied(ui.copied, ui.copy_delta);
(*ci)->add_copypassed(ui.copypassed);
(*ci)->add_changed(ui.changed);
(*ci)->writeFramebufferUpdateOrClose();
client->add_copied(ui.copied, ui.copy_delta);
client->add_copypassed(ui.copypassed);
client->add_changed(ui.changed);
client->writeFramebufferUpdateOrClose();
if (((network::UdpStream *)(*ci)->getOutStream(true))->isFailed()) {
((network::UdpStream *)(*ci)->getOutStream(true))->clearFailed();
(*ci)->udpDowngrade(true);
if (((network::UdpStream *)client->getOutStream(true))->isFailed()) {
((network::UdpStream *)client->getOutStream(true))->clearFailed();
client->udpDowngrade(true);
}
if (apimessager) {
(*ci)->sendStats(false);
const EncodeManager::codecstats_t subjpeg = (*ci)->getJpegStats();
const EncodeManager::codecstats_t subwebp = (*ci)->getWebpStats();
client->sendStats(false);
const EncodeManager::codecstats_t subjpeg = client->getJpegStats();
const EncodeManager::codecstats_t subwebp = client->getWebpStats();
jpegstats.ms += subjpeg.ms;
jpegstats.area += subjpeg.area;
@ -1163,8 +1161,8 @@ void VNCServerST::writeUpdate()
webpstats.area += subwebp.area;
webpstats.rects += subwebp.rects;
enctime += (*ci)->getEncodingTime();
scaletime += (*ci)->getScalingTime();
enctime += client->getEncodingTime();
scaletime += client->getScalingTime();
}
}