1187 commits

Author	SHA1	Message	Date
SergeantPanda	f98bb183da	Bug Fix: Fixed a provider TCP connection leak in the VOD proxy	2026-04-13 19:33:22 -05:00
SergeantPanda	55048b60e3	fix(vod-proxy): prevent double profile decrement and clean up stream counter naming	2026-04-13 18:40:33 -05:00
SergeantPanda	d73071b20f	Merge branch 'dev' of https://github.com/Dispatcharr/Dispatcharr into pr/firestaerter3/1125	2026-04-13 17:42:43 -05:00
SergeantPanda	f8407610c8	Bug Fix/Enhancement: Improve logic for get xc epg endpoint for short epgs. Also support epg_days from xc user for xc epg endpoint.	2026-04-12 18:51:40 -05:00
SergeantPanda	9f3d4ff7ff	Enhancement: Improved the EPG response cache key	2026-04-12 18:19:19 -05:00
SergeantPanda	ba967f47d9	Enhancement: **EPG historical data window**: the EPG XML output and XC EPG API now support a prev_days URL parameter (e.g. &prev_days=3) to include past programs in the EPG response. This allows third-party players that request historical program schedules to receive the data they need. The EPG URL builder in the Channels page exposes "Days forward" and "Days back" controls. Per-user defaults for both values (epg_days / epg_prev_days) can be configured in the User settings modal and are applied automatically when no URL parameter is present. (Closes #1154)	2026-04-12 16:34:15 -05:00
SergeantPanda	a83b9fdf62	Enhancement: EPG channel scanning now automatically removes stale EPGData entries.	2026-04-12 15:37:28 -05:00
SergeantPanda	b629836b3d	Bug Fix: Fixed stream switch metadata (url, user_agent, stream_id, m3u_profile) being written to Redis before the switch was confirmed to succeed	2026-04-12 12:02:20 -05:00
SergeantPanda	65d14644b4	Bug Fix: Fixed the next_stream rotation endpoint applying the same class of bug	2026-04-12 11:36:08 -05:00
SergeantPanda	ef030b3da0	Bug Fix: Manual stream selection from the Stats page not enforcing M3U profile connection limits in multi-worker deployments	2026-04-12 10:03:46 -05:00
SergeantPanda	f1a82e8843	Bug Fix: Fixed several incorrect or incomplete OpenAPI (@extend_schema) schemas across the API	2026-04-11 17:02:07 -05:00
SergeantPanda	1adbc70f53	Bug Fix: Fix bulk channel edit API when including streams array. (Fixes #883)	2026-04-11 16:11:45 -05:00
SergeantPanda	bfec229ca9	Enhancements: ... - Rewrote the M3U line parser as an `iter_m3u_entries` generator that owns the full per-entry state machine. Intermediate directive lines between `#EXTINF` and the stream URL are now handled correctly rather than corrupting the pending entry or being silently misassigned. A `#EXTINF` with no following URL is discarded with a warning instead of carrying over a `url`-less entry into batch processing. Attribute keys are normalised to lowercase during parsing (provider attribute names remain case-insensitive end-to-end). The `#EXTINF` attribute regex is pre-compiled at module load, and attribute lookups use O(1) `dict.get()` instead of linear scans — approximately 10% faster parsing on large M3U files. - Added support for the `#EXTGRP` directive in M3U files. When a `group-title` attribute is absent from the `#EXTINF` line, the value from a following `#EXTGRP:` line is used as the group. An explicit `group-title` attribute always takes priority. (Closes #1088) - Added accumulation of `#EXTVLCOPT` directives per entry. Options are stored as a list under `vlc_opts` inside the stream's `custom_properties`, available for downstream use (e.g. passing VLC-specific options to the player). This is for a planned future enhancement and can also be utlized with the API.	2026-04-11 14:57:52 -05:00
SergeantPanda	fd7ac0029d	Enhancement: M3U stream name parsing now uses the comma text (the canonical display title per the base #EXTINF spec) as the primary stream name, falling back to tvc-guide-title, then tvg-name, rather than preferring tvg-name first. Providers that use tvg-name as an EPG key and put the human-readable title after the comma will now display the correct name. Providers that duplicate the same value in both fields are unaffected. (Fixes #1081)	2026-04-11 12:46:36 -05:00
SergeantPanda	8afaa01184	security: Extended rate limiting to the session-auth login alias (POST /api/accounts/auth/login/). It now delegates entirely to TokenObtainPairView, inheriting its throttle, network access check, and audit logging, and returns JWT tokens instead of a session cookie (the session-based response was unusable since SessionAuthentication is not in DEFAULT_AUTHENTICATION_CLASSES). Both endpoints share the same "login" throttle scope, so attempts across either path count against the same per-IP limit.	2026-04-10 19:54:10 -05:00
SergeantPanda	e861fca092	Enhancement: Enhanced Swagger UI authorization dialog: registered a custom OpenApiAuthenticationExtension for ApiKeyAuthentication so drf-spectacular now generates an ApiKeyAuth (apiKey) entry alongside jwtAuth. Both entries include descriptive text linking to the relevant endpoints (/api/accounts/token/, /api/accounts/api-keys/generate/, /api/accounts/api-keys/revoke/).	2026-04-10 18:29:13 -05:00
Seth Van Niekerk	2573928e2a	enhance plugin installation and manifest fetching error handling with code review suggestions	2026-04-10 14:44:07 -04:00
Seth Van Niekerk	1cda7b9439	feat: plugin hub	2026-04-10 13:53:45 -04:00
SergeantPanda	c3fb9c0073	security: Fixed missing network_access_allowed checks in the VOD proxy. stream_vod, head_vod, stream_xc_movie, and stream_xc_episode were not checking the STREAMS network policy, unlike the equivalent TS proxy endpoints.	2026-04-10 11:09:27 -05:00
SergeantPanda	fa9a7868ff	security: proxy streaming endpoints (stream_ts, stream_xc, stream_vod, head_vod, stream_xc_movie, stream_xc_episode) use @permission_classes([AllowAny]) (access is controlled by the per-stream-type network allow-list inside the view body); the UserAgentViewSet, StreamProfileViewSet, CoreSettingsViewSet, and ProxySettingsViewSet gained get_permissions() methods mapping read actions to IsStandardUser and write actions to IsAdmin; and AuthViewSet.logout was updated to return [Authenticated()].	2026-04-10 10:47:50 -05:00
SergeantPanda	b535f28ac5	security: Added rate limiting to the login endpoint (POST /api/accounts/token/) using DRF's built-in throttling. A LoginRateThrottle (3 requests/minute per IP, sliding window) is applied to the TokenObtainPairView. Repeated failed attempts from the same IP receive 429 Too Many Requests.	2026-04-09 21:46:50 -05:00
SergeantPanda	47427d4b0f	security: ... - Set `DEFAULT_PERMISSION_CLASSES` to `Authenticated` in the DRF configuration. - Explicitly marked the HDHomeRun discovery endpoints (`DiscoverAPIView`, `LineupAPIView`, `LineupStatusAPIView`, `HDHRDeviceXMLAPIView`) and the version endpoint with `permission_classes = [AllowAny]` to document their intentionally public access now that the global default is `Authenticated`.	2026-04-09 21:36:51 -05:00
SergeantPanda	7083c512be	security: Fixed path traversal vulnerability in file uploads. The M3U account upload (apps/m3u/api_views.py), logo upload (apps/channels/api_views.py), and backup upload (apps/backups/api_views.py) all used the uploaded filename directly without sanitization. os.path.join() discards all preceding components when it encounters an absolute path segment, and pathlib's / operator behaves identically; a relative ../ sequence also escapes via OS path resolution at open() time. All three upload paths now strip directory components via Path(name).name and validate the resolved path remains within the intended upload directory. Exploiting any of these required admin credentials.	2026-04-09 21:32:36 -05:00
SergeantPanda	08545b8c92	security: Prevented users from setting xc_password (and other admin-managed keys) on their own account via the PATCH /api/accounts/users/me/ endpoint.	2026-04-09 21:31:38 -05:00
SergeantPanda	dcefc6541c	chore(cleanup): - Removed dead VODConnectionManager class (apps/proxy/vod_proxy/connection_manager.py) and its associated helpers, which had been superseded by MultiWorkerVODConnectionManager. All active code already used the multi-worker implementation. Removed the unused VODConnectionManager import from vod_proxy/views.py, the unscheduled cleanup_vod_connections task from apps/proxy/tasks.py, and the unscheduled cleanup_vod_persistent_connections task from core/tasks.py. ... - Removed dead VOD URL routes: `VODPlaylistView` (playlist generation), `VODPositionView` (position tracking), and the class-based `VODStatsView` (replaced by the existing function-based `vod_stats` view). - Removed dead `updateVODPosition()` API method from `frontend/src/api.js`, which called the now-removed position tracking endpoint.	2026-04-09 19:59:50 -05:00
SergeantPanda	7f64642003	security: Hardened the HLS proxy change_stream endpoint by converting it from a plain Django view to a DRF @api_view with @permission_classes([IsAdmin]), ensuring the endpoint actually enforces admin-only access. The previous decorator arrangement (@csrf_exempt + @permission_classes) had no effect on a plain Django view.	2026-04-09 19:58:40 -05:00
SergeantPanda	10582a3741	Enhancement: Improved the EPG BOM fix from v0.22.1: replaced the lstrip(b'\xef\xbb\xbf') / startswith approach with start.find(b'<?xml'), which locates the XML declaration regardless of any leading bytes BOM, whitespace, or other encoding markers without needing to know what those bytes are.	2026-04-09 11:16:04 -05:00
dwot	b01ec466f1	Fix for #1173 ErsatzTV EPG not populating / fix for UTF-8 BOM processing	2026-04-04 22:15:28 -04:00
SergeantPanda	6f8ca243af	fix: ensure PGSSL* environment variables are explicitly set by stripping inherited values ... fix: use psycopg2.sql for safe database drop and create commands fix: Also check POSTGRES_SSL is true before skipping default POSTGRES_PASSWORD fix: update usage comment to reflect correct script path fix: improve cleanup logic to conditionally remove certificate directory	2026-03-31 09:51:09 -05:00
None	763f42cfff	fix: pass TLS parameters to all external connection points in modular mode ... - Add setup_pg_ssl_env() to export libpq PGSSL* env vars; all child psql/pg_dump/pg_isready commands inherit TLS automatically - Move TLS client key permission fix before external PG connections (was running after, defeating the fix) - Enhance key fix to trigger on ownership mismatch (root-owned 0600 key unreadable by app user) - Extract key fix to shared script (docker/init/00-fix-pg-ssl-key.sh) sourced by both entrypoints - Default POSTGRES_PASSWORD to empty in modular mode (cert-only auth sends no spurious password) - Propagate TLS OPTIONS to backup pg_dump/pg_restore subprocess calls via _get_pg_env() - Pass SSL kwargs to dropdb management command's psycopg2.connect() - Add REDIS_SSL_PARAMS to VOD proxy Redis connections missed in original TLS PR - Add 8-scenario TLS integration test suite (PG mTLS, Redis TLS, verify-full, key fix, Celery, regression) - Add 6 unit tests for _get_pg_env() and dropdb TLS parameter passing	2026-03-30 20:19:27 -05:00
SergeantPanda	70e229a433	Refactor HTML entity handling in XMLTV files: replace regex-based entity resolution with lxml's html.entities for improved accuracy and performance. Inject DOCTYPE declaration to ensure proper parsing of HTML entities, avoiding silent drops during recovery mode.	2026-03-29 20:43:27 -05:00
SergeantPanda	d4ecf45bc2	Bug Fix/Enhancement: ... - EPG refresh tasks (`refresh_epg_data`) were being killed mid-transaction on large EPG sources. The `soft_time_limit=1700s` introduced in v0.21.0 raised `SoftTimeLimitExceeded`, a subclass of `Exception`, which was swallowed by the existing `except Exception` handler in `parse_programs_for_source`, leaving the database in a partial state with no logged error. The underlying cause is that the HTML entity preprocessing step added in v0.21.0 adds 2–10+ minutes on multi-gigabyte EPG files, pushing total task duration past the 1700s limit for large sources. `soft_time_limit` has been removed from `refresh_epg_data` and `time_limit` raised to 14400s (4 hours) as a true last-resort ceiling; the existing `TaskLockRenewer` daemon thread continues to renew the Redis lock every 120s for legitimately long-running tasks. - HTML entity preprocessing (`_resolve_html_entities`) now performs a fast binary pre-scan before any file read or write. The pre-scan reads the file in 4 MB chunks without text decoding and exits immediately on the first non-XML named entity found. For EPG sources that contain no HTML entities — the common case — the full line-by-line read+rewrite pass (which takes 2–10+ minutes on a 2.5 GB file) is skipped entirely.	2026-03-29 19:51:57 -05:00
SergeantPanda	086cc74959	Bug Fix: M3U profile URL rewriting now uses the regex module instead of re across all URL transform code paths (url_utils.transform_url, core/views.py, vod_proxy/_transform_url, tasks.get_transformed_credentials, and the WebSocket live-preview handler in consumers.py). The regex module natively accepts JavaScript/PCRE-style named capture groups ((?<name>...)) without any conversion, eliminating the root cause of patterns that matched in the frontend live preview but failed on the backend with a re.error. As a further improvement, regex also supports variable-length lookbehind assertions (e.g. (?<=a+)), which re rejects with an error; patterns using these will now work correctly on the backend as well. Replace-pattern JS tokens are still normalised before calling regex.sub: $<name> → \g<name> and $1/$2/… → \1/\2/… (Python replacement syntax). Also fixed a bug in the WebSocket preview handler where a pattern error was incorrectly returning the search pattern string as the preview output instead of the original URL. (Fixes #1005)	2026-03-29 17:55:08 -05:00
SergeantPanda	6d06422ddd	Enhancement: client_connect and client_disconnect system events now include the **username** of the connected user. The username is stored alongside the client metadata in Redis and included in the event payload for log_system_event calls (making it available to webhook and script integrations).	2026-03-29 16:06:14 -05:00
SergeantPanda	f00d1fe63c	Bug Fix/Enhancement: ... - Web UI stream preview (`FloatingVideo`) was calling `mpegts.createPlayer()` with all `Config` options (e.g. `enableWorker`, `liveSync`, `headers`) merged into the first `MediaDataSource` argument. mpegts.js only reads `Config` from the optional second argument; unrecognised fields in the first are silently ignored. As a result all player configuration was effectively the library defaults — worker offloading was disabled, latency management had no effect, and the `Authorization: Bearer` header (required for user identification) was never sent. Fixed by splitting into the correct two-argument call. Both `liveBufferLatencyChasing` and `liveSync` have been disabled, eliminating playback-rate fluctuations that caused audible stuttering on live streams. SourceBuffer cleanup thresholds were also relaxed from 10s/5s to 120s/60s to prevent frequent SourceBuffer pauses. - Web UI stream preview now sends an `Authorization: Bearer` header with each mpegts.js request, identifying the logged-in user. Live channel previews initiated from the web UI now appear on the Stats page with the correct username rather than as unknown user.	2026-03-28 18:04:11 -05:00
SergeantPanda	38f5156ca6	Enhancement: Show username in VOD cards.	2026-03-28 16:46:06 -05:00
SergeantPanda	dd97b642c7	Bug Fix: preserve original file mtime during HTML entity resolution to prevent infinite refresh loop	2026-03-28 14:21:37 -05:00
SergeantPanda	5f4e066147	Enhancements: ... - Connection cards on the Stats page now show the **username** of the connected user in a new User column (between IP Address and Connected). The username is resolved from the user store using the `user_id` stored in Redis client metadata; unauthenticated connections display "Anonymous". (Closes #766) - `ip_address` and `user_id` were not included in the client info returned by `get_detailed_channel_info()` despite being available in the Redis hash. Both fields are now extracted and returned. (Closes #586)	2026-03-28 13:33:29 -05:00
SergeantPanda	7964b2c2cb	fix: enhance stream termination logic to handle multiple connections on the same channel	2026-03-26 20:33:03 -05:00
SergeantPanda	46d4063524	fix: change logging level from info to debug in user connection checks	2026-03-26 20:10:03 -05:00
SergeantPanda	aa6fb033d3	fix: update user stream limit checks to include media_id and rename user_limits_settings key	2026-03-26 20:02:54 -05:00
SergeantPanda	58befaa52b	fix: correct indentation in check_user_stream_limits function	2026-03-26 19:14:46 -05:00
SergeantPanda	b671a72707	fix: resolve decode_responses migration bugs and user-limit regressions ... Fix a wave of bugs introduced by the user-priority branch's migration from manual .decode('utf-8') calls to decode_responses=True on the metadata Redis client: core/utils.py - Rewrite _init_client: fix SyntaxError at line 138, missing redis_password/redis_user params, cls._client corruption when decode_responses=False was requested, and dead retry backoff logic apps/proxy/utils.py - Fix get_user_limit_settings() → get_user_limits_settings() (2 sites) - Fix VOD scan key vod_persistent_connections:* → vod_persistent_connection:* - Fix undefined channel_id in VOD loop (use content_uuid from Redis hash) - Remove leftover print(active_connections) debug statement - Refactor manual cursor SCAN while-loops to scan_iter() apps/channels/tasks.py - Fix closure bug in _d(): md.get(key) → md.get(bkey) (was reading the outer loop variable instead of the local bytes key) apps/proxy/ts_proxy/server.py - Replace stale b'init_time', b'total_bytes', b'state' byte-string key lookups and .decode() calls with plain string equivalents apps/proxy/ts_proxy/services/channel_service.py - Fix ChannelMetadataField.STATE.encode() / .OWNER.encode() → .STATE / .OWNER (pre-existing, broke under decoded client) apps/proxy/ts_proxy/views.py - Fix ChannelMetadataField.OWNER.encode("utf-8") → .OWNER apps/proxy/ts_proxy/client_manager.py - Fix cid.decode('utf-8') in remove_ghost_clients(): smembers() already returns str with decode_responses=True	2026-03-26 18:41:42 -05:00
dekzter	90a600b48f	merged in dev	2026-03-26 12:17:43 -04:00
SergeantPanda	5095f8d5ce	Merge pull request #1099 from CodeBormen/fix/1095-epg-special-characters ... fix: resolve HTML named entities in XMLTV files before parsing	2026-03-26 10:07:59 -05:00
dekzter	a19be96ced	fleshed out user limits and termination logic	2026-03-25 17:33:26 -04:00
SergeantPanda	cee94282f9	Merge pull request #1128 from CodeBormen/dev ... feat: add TLS connection support for Redis and PostgreSQL (#950)	2026-03-24 18:56:57 -05:00
SergeantPanda	034f0623bf	fix(tasks): handle AttributeError in series rule evaluation lock acquisition and release	2026-03-23 17:48:35 -05:00
None	b30a24e2fb	feat: add TLS connection support for Redis and PostgreSQL (#950) ... - Add 10 env vars for Redis/PostgreSQL TLS (REDIS_SSL, REDIS_SSL_VERIFY, REDIS_SSL_CA_CERT, REDIS_SSL_CERT, REDIS_SSL_KEY, POSTGRES_SSL, POSTGRES_SSL_MODE, POSTGRES_SSL_CA_CERT, POSTGRES_SSL_CERT, POSTGRES_SSL_KEY) - Propagate SSL params to all Redis connection points: RedisClient, stream view, PubSub, client manager, Celery broker/result backend, Django Channels, and pre-Django startup scripts - Add Celery SSL config via URL query string params (required by Kombu's internal URL parsing) - Add PostgreSQL sslmode and certificate options to DATABASES config - Add startup validation: cert file existence, URL scheme conflict detection, TLS status logging - Add TLS error hints to Redis connection failure messages - Add Connection Security panel in System Settings (modular mode only) showing encryption, verification, and mTLS status - Add PG client key permission fix in web and celery entrypoints for Docker Desktop compatibility (0777 to 0600) - Add TLS env var passthrough in entrypoint for su - login shells - Document TLS env vars in modular docker-compose.yml - Change env_mode from dev/prod to actual DISPATCHARR_ENV value for modular mode detection	2026-03-21 17:24:09 -05:00
None	36a8e92d94	fix(dvr): prevent duplicate recordings after EPG refresh ... - Replace ProgramData.id-based dedup with stable (tvg_id, start_time, end_time) key from Recording.custom_properties.program. ProgramData IDs change on every EPG refresh; the old dedup always passed after refresh, creating duplicates. - Fix secondary timeslot guard to compare original program times (stored in custom_properties) instead of offset-adjusted Recording times. With DVR pre/post offsets configured, the old guard never matched. - Add acquire_task_lock/release_task_lock to serialize concurrent evaluate_series_rules calls. Multiple EPG source refreshes firing evaluate_series_rules.delay() simultaneously raced to create duplicate recordings.	2026-03-20 11:48:06 -05:00