From 61d713fcda5ac6ffd90286c8512d64ff83e222c6 Mon Sep 17 00:00:00 2001 From: SergeantPanda Date: Sat, 21 Mar 2026 15:14:58 -0500 Subject: [PATCH] test: update validation for empty CIDR range to allow defaults on submit --- .../settings/__tests__/NetworkAccessForm.test.jsx | 15 ++++++++------- .../__tests__/NetworkAccessFormUtils.test.js | 3 ++- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/frontend/src/components/forms/settings/__tests__/NetworkAccessForm.test.jsx b/frontend/src/components/forms/settings/__tests__/NetworkAccessForm.test.jsx index 15e5e430..d3008354 100644 --- a/frontend/src/components/forms/settings/__tests__/NetworkAccessForm.test.jsx +++ b/frontend/src/components/forms/settings/__tests__/NetworkAccessForm.test.jsx @@ -313,10 +313,10 @@ describe('NetworkAccessForm', () => { fireEvent.click(screen.getByTestId('confirm-ok')); await waitFor(() => { - expect(screen.getByTestId('alert')).toBeInTheDocument(); - expect(screen.getByTestId('alert-title')).toHaveTextContent( - 'Saved Successfully' - ); + const alertTitles = screen.getAllByTestId('alert-title'); + expect( + alertTitles.some((el) => el.textContent === 'Saved Successfully') + ).toBe(true); }); }); @@ -399,9 +399,10 @@ describe('NetworkAccessForm', () => { fireEvent.click(screen.getByTestId('confirm-ok')); await waitFor(() => { - expect(screen.getByTestId('alert-title')).toHaveTextContent( - 'Saved Successfully' - ); + const alertTitles = screen.getAllByTestId('alert-title'); + expect( + alertTitles.some((el) => el.textContent === 'Saved Successfully') + ).toBe(true); }); }); }); diff --git a/frontend/src/utils/forms/settings/__tests__/NetworkAccessFormUtils.test.js b/frontend/src/utils/forms/settings/__tests__/NetworkAccessFormUtils.test.js index 11438d00..2cc885ec 100644 --- a/frontend/src/utils/forms/settings/__tests__/NetworkAccessFormUtils.test.js +++ b/frontend/src/utils/forms/settings/__tests__/NetworkAccessFormUtils.test.js @@ -131,7 +131,8 @@ describe('NetworkAccessFormUtils', () => { NetworkAccessFormUtils.getNetworkAccessFormValidation(); const validator = validation['network-access-admin']; - expect(validator('')).toBe('Invalid CIDR range'); + // Empty values are allowed — defaults are substituted on submit + expect(validator('')).toBe(null); }); it('should return empty object when NETWORK_ACCESS_OPTIONS is empty', () => {