Mirrors/Dispatcharr
1
0
Fork 1
mirror of https://github.com/Dispatcharr/Dispatcharr.git synced 2026-07-18 09:06:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Performance: Fixed N+1 UPDATE queries in the stream-order write path

Browse source
This commit is contained in:
SergeantPanda 2026-04-19 09:55:56 -05:00
parent 17fbf1d4f7
commit 452a493df3
2 changed files with 10 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
apps/channels/api_views.py
View file

@ -797,17 +797,21 @@ class ChannelViewSet(viewsets.ModelViewSet):
if to_remove:
channel.channelstream_set.filter(stream_id__in=to_remove).delete()
to_update = []
for order, stream_id in enumerate(normalized_ids):
if stream_id in current_links:
cs = current_links[stream_id]
if cs.order != order:
cs.order = order
cs.save(update_fields=["order"])
to_update.append(cs)
else:
ChannelStream.objects.create(
channel=channel, stream_id=stream_id, order=order
)
if to_update:
ChannelStream.objects.bulk_update(to_update, ["order"])
# Return the updated objects (already in memory)
serialized_channels = ChannelSerializer(
[channel for channel, _ in validated_updates],

7
apps/channels/serializers.py
View file

@ -365,7 +365,6 @@ class ChannelSerializer(serializers.ModelSerializer):
normalized_ids = [
stream.id if hasattr(stream, "id") else stream for stream in streams
]
print(normalized_ids)
# Get current mapping of stream_id -> ChannelStream
current_links = {
@ -382,17 +381,21 @@ class ChannelSerializer(serializers.ModelSerializer):
instance.channelstream_set.filter(stream_id__in=to_remove).delete()
# Update or create with new order
to_update = []
for order, stream_id in enumerate(normalized_ids):
if stream_id in current_links:
cs = current_links[stream_id]
if cs.order != order:
cs.order = order
cs.save(update_fields=["order"])
to_update.append(cs)
else:
ChannelStream.objects.create(
channel=instance, stream_id=stream_id, order=order
)
if to_update:
ChannelStream.objects.bulk_update(to_update, ["order"])
return instance
def validate_channel_number(self, value):