From 303123f3ec1854d70f1f39f12ef26cca14a3d7d2 Mon Sep 17 00:00:00 2001
From: SergeantPanda <chester.cullen@gmail.com>
Date: Wed, 21 May 2025 09:44:09 -0500
Subject: [PATCH] Buffer overflow error.

---
 apps/proxy/ts_proxy/stream_manager.py | 45 +++++++++++++++------------
 docker/uwsgi.debug.ini                |  1 +
 docker/uwsgi.dev.ini                  |  3 +-
 docker/uwsgi.ini                      |  3 +-
 4 files changed, 30 insertions(+), 22 deletions(-)

diff --git a/apps/proxy/ts_proxy/stream_manager.py b/apps/proxy/ts_proxy/stream_manager.py
index 7d158c09..054de05b 100644
--- a/apps/proxy/ts_proxy/stream_manager.py
+++ b/apps/proxy/ts_proxy/stream_manager.py
@@ -376,28 +376,33 @@ class StreamManager:
             logger.debug(f"Started stderr reader thread for channel {self.channel_id}")
 
     def _read_stderr(self):
-        """Read and log stderr output from the transcode process"""
+        """Read and log ffmpeg stderr output"""
         try:
-            if not self.transcode_process or not self.transcode_process.stderr:
-                logger.warning(f"No stderr to read for channel {self.channel_id}")
-                return
-
-            for line in iter(self.transcode_process.stderr.readline, b''):
-                if not line:
-                    break
-
-                # Decode the line and strip whitespace
-                error_line = line.decode('utf-8', errors='replace').strip()
-
-                # Skip empty lines
-                if not error_line:
-                    continue
-
-                # Log all stderr output as debug messages
-                logger.debug(f"Transcode stderr [{self.channel_id}]: {error_line}")
-
+            for error_line in iter(self.transcode_process.stderr.readline, b''):
+                if error_line:
+                    error_line = error_line.decode('utf-8', errors='replace').strip()
+                    try:
+                        # Wrap the logging call in a try-except to prevent crashes due to logging errors
+                        logger.debug(f"Transcode stderr [{self.channel_id}]: {error_line}")
+                    except OSError as e:
+                        # If logging fails, try a simplified log message
+                        if e.errno == 105:  # No buffer space available
+                            try:
+                                # Try a much shorter message without the error content
+                                logger.warning(f"Logging error (buffer full) in channel {self.channel_id}")
+                            except:
+                                # If even that fails, we have to silently continue
+                                pass
+                    except Exception:
+                        # Ignore other logging errors to prevent thread crashes
+                        pass
         except Exception as e:
-            logger.error(f"Error reading transcode stderr: {e}")
+            # Catch any other exceptions in the thread to prevent crashes
+            try:
+                logger.error(f"Error in stderr reader thread: {e}")
+            except:
+                # Again, if logging fails, continue silently
+                pass
 
     def _establish_http_connection(self):
         """Establish a direct HTTP connection to the stream"""
diff --git a/docker/uwsgi.debug.ini b/docker/uwsgi.debug.ini
index ea567e1e..6ca855f3 100644
--- a/docker/uwsgi.debug.ini
+++ b/docker/uwsgi.debug.ini
@@ -47,6 +47,7 @@ thunder-lock = true
 log-4xx = true
 log-5xx = true
 disable-logging = false
+log-buffering = 1024  # Add buffer size limit for logging
 
 ; Longer timeouts for debugging sessions
 harakiri = 3600
diff --git a/docker/uwsgi.dev.ini b/docker/uwsgi.dev.ini
index 62a5f352..f3e5238e 100644
--- a/docker/uwsgi.dev.ini
+++ b/docker/uwsgi.dev.ini
@@ -57,4 +57,5 @@ log-master = true
 logformat-strftime = true
 log-date = %%Y-%%m-%%d %%H:%%M:%%S,000
 # Use formatted time with environment variable for log level
-log-format = %(ftime) $(DISPATCHARR_LOG_LEVEL) uwsgi.requests Worker ID: %(wid) %(method) %(status) %(uri) %(msecs)ms
\ No newline at end of file
+log-format = %(ftime) $(DISPATCHARR_LOG_LEVEL) uwsgi.requests Worker ID: %(wid) %(method) %(status) %(uri) %(msecs)ms
+log-buffering = 1024  # Add buffer size limit for logging
\ No newline at end of file
diff --git a/docker/uwsgi.ini b/docker/uwsgi.ini
index 5068268c..32eb6e3c 100644
--- a/docker/uwsgi.ini
+++ b/docker/uwsgi.ini
@@ -55,4 +55,5 @@ log-master = true
 logformat-strftime = true
 log-date = %%Y-%%m-%%d %%H:%%M:%%S,000
 # Use formatted time with environment variable for log level
-log-format = %(ftime) $(DISPATCHARR_LOG_LEVEL) uwsgi.requests Worker ID: %(wid) %(method) %(status) %(uri) %(msecs)ms
\ No newline at end of file
+log-format = %(ftime) $(DISPATCHARR_LOG_LEVEL) uwsgi.requests Worker ID: %(wid) %(method) %(status) %(uri) %(msecs)ms
+log-buffering = 1024  # Add buffer size limit for logging
\ No newline at end of file